Symphony.

I can confirm the bug and the fix, and I did not notice any side effects.

However, I think there might be a more elegant solution to build the $where string in the patch. If the code is considered fine, it should be pulled (and trailing whitespace might be removed).

[EDIT]: Maybe @brendo can take a look?

Probably there would be something more elegant but did first thing that came to mind - as the view was required on a project I am working on; better have it working then not.

Hopefully I can start contributing to the community slowly :)

I really appreciate your fix, and actually I had no idea how to make it "more elegant". :-)

I just thought that @brendo might take a look because I know that he is around 328 times better than me when it comes to PHP coding! :-))

I'll hold off,but hat off to @gunglien for spotting it. (It could also fix a bug in one of my extensions)

I found the same bug when selecting multiple pages, and @gunglien's fix worked.
But the extension has not been updated yet...

Is this logged on github? I plan to go through the issue trackers for Symphonists and Symphony extensions at some point soon.

yep issue is logged into github and there is a pull request. I've fixed some small things for 2.3 compatibility on a local copy at home if you want I can possibly issue pull requests as well once 2.3 is out so I don't mess it all up yet :)

I'm also pretty sure that klaftertief was updating this field heavily to use the new PageManager class. I made a start but held back when I found he was doing this. Not sure if he's send pull requests yet or not though.

ahh if its already being done best not to touch then :)

I updated most page related SQL queries to use the new PageManager, but haven't send any pull requests because I didb't touch the getToggleStates() method. The reason was that the PageManager (PM) doesn't support to query by multiple page types. Also I wanted to add a negation filter, which the PM doesn't have. Didn't find the time to implement it properly, only did some SQL research. This linked issue is about the Navigation DS though, but both areas would benefit.

I could prepare a pull request for the normal queries later today, but maybe we should discuss and wait for the more complex stuff at first.