(2.0.7) XML result from "Allow Multiple" Events feels broken
Closed ticket reported by nickdunn on 05 January 2010
# 199Closed Ticket: (2.0.7) XML result from "Allow Multiple" Events feels broken
-
-
- nickdunn
- Comment #1
- 05 Jan 10, 7:41 pm
-
-
- nickdunn
- Comment #2
- 08 Jan 10, 8:26 am
-
-
- Alistair
- Comment #3
- 11 Jan 10, 8:50 am
Pull Accepted. Fixed
This issue is closed.
XML from events between 2.0.6 and 2.0.7 appears identical for single-entry events, however Allow Multiple exhibits odd results in 2.0.7.
In 2.0.6 sending two entries in a post (a required image and a checkbox that is ticked):
<events> <save-user> <entry position="0" result="error"> <message>Entry encountered errors when saving.</message> <profile type="missing" message="'Profile' is a required field." /> <post-values> <enabled>on</enabled> </post-values> </entry> <entry position="1" result="error"> <message>Entry encountered errors when saving.</message> <profile type="missing" message="'Profile' is a required field." /> <post-values> <enabled>on</enabled> </post-values> </entry> </save-user> </events>And in 2.0.7:
<events> <save-user> <entry position="0" result="error"> <message>Entry encountered errors when saving.</message> <profile type="missing" message="'Profile' is a required field." /> <post-values> <item index="1"> <enabled>on</enabled> </item> <item index="2"> <enabled>on</enabled> </item> </post-values> </entry> <entry position="1" result="error"> <message>Entry encountered errors when saving.</message> <profile type="missing" message="'Profile' is a required field." /> <post-values> <item index="1"> <enabled>on</enabled> </item> <item index="2"> <enabled>on</enabled> </item> </post-values> </entry> </save-user> </events>Looks like the change in
event.section.phpline 24 is the offender:While neat and elegant, the XML returned appears incorrect in several ways:
itemnodes are created for each entry, should only be oneitemnodes created at all?At the moment this breaks backwards compatibility and feels broken.